test(e2e): ensure proper cleanup of build after execution#5441
Merged
chenjiahan merged 1 commit intomainfrom Jun 19, 2025
Merged
test(e2e): ensure proper cleanup of build after execution#5441chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the build’s internal resources are cleaned up by capturing and invoking the close callback returned from rsbuild.build().
- Store the build-close function (
result.close) incloseBuild - Invoke
closeBuildbefore shutting down the preview server and restoring console proxy - Update the cleanup logic in the returned
closehandler
Comments suppressed due to low confidence (2)
e2e/scripts/shared.ts:283
- [nitpick] Add a brief comment explaining what
closeBuildrepresents and when it might be undefined to aid future maintainers.
let closeBuild: () => Promise<void> | undefined;
e2e/scripts/shared.ts:331
- Consider adding an E2E or unit test that verifies
closeBuildis actually invoked and that build-related resources are released correctly.
await closeBuild?.();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure proper resource cleanup after the E2E build process.
Checklist